Skip to content

Conversation

@phra
Copy link
Member

@phra phra commented Jul 2, 2016

simple maintenance.

@Foxandxss
Copy link
Member

I appreciate the PR but I am not sure I want that jsconfig (which won't work because has comments) and not sure if I want typings for this project.

@phra phra force-pushed the master branch 2 times, most recently from beefc3b to 0f1793e Compare July 2, 2016 13:49
@phra phra changed the title update deps and install npm-check update deps, install npm-check and add intellisense Jul 2, 2016
@phra
Copy link
Member Author

phra commented Jul 2, 2016

i've fixed the jsconfig.json file that was created by vscode and added typings.json config for intellisense.
feel free to merge or close this PR.

cheers.

@Foxandxss
Copy link
Member

I will accept a PR where dependencies are updated but not the typings nor the jsconfig. That can be added for you locally for your project.

@phra
Copy link
Member Author

phra commented Jul 2, 2016

as you prefer, done.

@phra phra changed the title update deps, install npm-check and add intellisense update deps and install npm-check Jul 2, 2016
@Foxandxss
Copy link
Member

Also not that npm-check, sorry.

@phra phra changed the title update deps and install npm-check update deps Jul 4, 2016
@phra
Copy link
Member Author

phra commented Jul 4, 2016

i've stripped away npm-check. (btw what's wrong with that?)

@Foxandxss
Copy link
Member

npm-check is better installed globally so you can npm-check any project of yours. Better than having to install it by hand to every project.

@Foxandxss Foxandxss merged commit d8411dd into preboot:master Jul 4, 2016
@phra
Copy link
Member Author

phra commented Jul 4, 2016

i'm against to global deps. (what if i have two project with different semver compatibility of a certain tool/library?)

i prefer the $PATH approach, i.e.

 $ export $PATH=$PATH:./node_modules/.bin

and installing everything locally.

@Foxandxss
Copy link
Member

I agree on that, but is not the case of this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants